Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort release tags *after* limiting #15

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Sep 19, 2023

Thanks a lot for implementing #13. Unfortunately, sortAscending = false is not very useful unless one also sets numtagstodisplay = -1, because the n releases since inception instead of since last release - 30 are displayed.

Currently, with defaults plus sortAscending = false:

> hvm use

  1) v0.63.2               2) v0.63.1               3) v0.63.0             
  4) v0.62.2               5) v0.62.1               6) v0.62.0             
  7) v0.61.0               8) v0.60.1               9) v0.60.0             
 10) v0.59.1              11) v0.59.0              12) v0.58.3             
 13) v0.58.2              14) v0.58.1              15) v0.58.0             
 16) v0.57.2              17) v0.57.1              18) v0.57.0             
 19) v0.56.3              20) v0.56.2              21) v0.56.1             
 22) v0.56.0              23) v0.55.6              24) v0.55.5             
 25) v0.55.4              26) v0.55.3              27) v0.55.2             
 28) v0.55.1              29) v0.55.0              30) v0.54.0

This PR should fix that.

Note that I have almost zero experience in Golang, so please bear with me if style or anything is not how you like it.

@salim-b salim-b force-pushed the patch-1 branch 2 times, most recently from af0eaf3 to d95c43d Compare September 19, 2023 00:45
cmd/hvm/use.go Outdated Show resolved Hide resolved
Co-authored-by: Joe Mooring <[email protected]>
@jmooring jmooring merged commit ea50f29 into jmooring:main Sep 19, 2023
5 checks passed
@salim-b salim-b deleted the patch-1 branch September 19, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants