[ruby] Persist JRuby Script Container with Environment #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persisting the lazily created JRuby execution environment and loaded global variables with cleaning up only happening at shutdown. This removes the overhead of JRuby instantiating a Ruby environment for each RubySrc2Cpg.
…-script-container
ml86
requested changes
Feb 18, 2025
Comment on lines
+48
to
+53
| val astGenResult = persistedRubyAstGenRunner match { | ||
| case Some(astGenRunner) => | ||
| astGenRunner.execute(tmpDir, config) | ||
| case None => | ||
| Using.resource(RubyAstGenRunner(config))(_.execute(tmpDir)) | ||
| } |
There was a problem hiding this comment.
If we create the runner here on demand for the non server scenario, when not always create it here on demand?
And i suggest we let X2CpgFrontend extend AutoClosable so that the close call can be handled be X2CpgFrontend and not in the individual frontend Main classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persisting the lazily created JRuby execution environment and loaded global variables with cleaning up only happening at shutdown.
This removes the overhead of JRuby instantiating a Ruby environment for each RubySrc2Cpg.