Replace scala.sys.Process
#5317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joern-cli/frontends/x2cpg/src/main/scala/io/joern/x2cpg/utils/ExternalCommand.scala
Outdated
Show resolved
Hide resolved
…references to new ExternalCommand
AndreiDreyer
requested review from
mpollmeier,
max-leuthaeuser,
ml86 and
DavidBakerEffendi
DavidBakerEffendi
changed the title
scala.sys.Processscala.sys.Process
There was a problem hiding this comment.
I don't quite get it sorry.
- We now carry two almost identical implementation around. (semanticcpg and sbt)
- User downstream need to change the dependency from x2cpg to semanticcpg or at it additionaly
- Scala process is a wrapper around Java processbuilder anyway
- Every invocation is now more complicated, e.g., if std out/err is not used and one only is interested in the return value
- Especially at the sbt side of things simply using Scala process looks cleaner
DavidBakerEffendi
added
infrastructure
ml86
requested changes
Feb 20, 2025
semanticcpg/src/main/scala/io/shiftleft/semanticcpg/utils/ExternalCommand.scala
Outdated
Show resolved
Hide resolved
| @@ -1,10 +1,11 @@ | |||
| package io.joern.x2cpg.utils | |||
| package io.shiftleft.semanticcpg.utils | |||
There was a problem hiding this comment.
In order to not make this a breaking change, make object ExternalCommand a trait or class and with e.g. an Impl suffix and have two objects extend it, one in the old and one in the new namespace. Please put a deprecation warning on the old namespace version. That way we dont break anything without a headsup.
…s.Process. Re-added io.joern.x2cpg.utils.ExternalCommand with Deprecated annotation. Added io.shiftleft.semanticcpg.utils.ExternalCommandImpl trait
…s.Process. Re-added io.joern.x2cpg.utils.ExternalCommand with Deprecated annotation. Added io.shiftleft.semanticcpg.utils.ExternalCommandImpl trait
joern-cli/frontends/c2cpg/src/main/scala/io/joern/c2cpg/utils/GccSpecificExternalCommand.scala
Outdated
Show resolved
Hide resolved
.../frontends/gosrc2cpg/src/main/scala/io/joern/gosrc2cpg/passes/DownloadDependenciesPass.scala
Outdated
Show resolved
Hide resolved
DavidBakerEffendi
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala.sys.Processwithjava.lang.ProcessBuilderio.joern.x2cpg.utils.ExternalCommandtoio.shiftleft.semanticcpg.utils.ExternalCommandso it can be used in the required placesExternalCommandthat allows the process to run in the current directory inherited from the Java parentExternalCommandUtil, which replicates some ofExternalCommand.scalafunctionality so that it can be used inbuild.sbtfiles