Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Android 15 instead of Android 14 #3918

Closed

Conversation

tegridyfarmer
Copy link

To do this I edited the build.gradle

Description

It targets and compiles for Android 15 instead of Adroid 14.
Here are some relevant things to keep in mind before merging:
https://developer.android.com/about/versions/15/behavior-changes-15

Issues Resolved

#3884

Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

To do this I edited the build.gradle
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there tegridyfarmer! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@johannesjo
Copy link
Owner

Thanks for opening this up! Did you test if the android app builds and works with this change?

@tegridyfarmer
Copy link
Author

No, I can try it but I have never made a build. Do I need to use Android Studio for that?

@johannesjo
Copy link
Owner

No, I can try it but I have never made a build. Do I need to use Android Studio for that?

Yes!

@tegridyfarmer
Copy link
Author

tegridyfarmer commented Jan 30, 2025

I managed to build two debug-builds using ./gradlew assembleDebug.
https://github.com/tegridyfarmer/super-productivity/releases/tag/target-android-15

The application seems to work normally, but does mention that it is in debug mode as notification on the bottom on app start.
Should I have built it differently using npm run dist:android, npm run dist:android:prod or assembleRelease?

@tegridyfarmer
Copy link
Author

tegridyfarmer commented Feb 3, 2025

On another application (PrivateLock) I used assembleRelease and it has worked great without the notification. So that was it.

Currently I guess some testing has to be done on an Android 15 device or in a Android 15 emulator like in Android Studio.

@johannesjo
Copy link
Owner

johannesjo commented Feb 4, 2025

Currently I guess some testing has to be done on an Android 15 device or in a Android 15 emulator like in Android Studio

Yes! I think checking if all basic stuff works (creating some tasks), should be enough. Could you have a look?

@tegridyfarmer
Copy link
Author

If I have some time I will try and test it in Android Studio with a Android 15 build this weekend.
And I will send a screen recording of it here.

@johannesjo
Copy link
Owner

johannesjo commented Feb 5, 2025

No screen recording needed. Thanks. I trust you :) Just testing once would be great!

@tegridyfarmer
Copy link
Author

image

There are some issues: this is likely caused by the end-to-end display mode that Android 15 uses for apps.
Currently I can not go further than the time tracking instruction as it it shown under the notifcation bar.
This is an issue I encountered on the Pixel 8 with Android 15 in Android studio.

What do you think a fitting solution is?

@johannesjo
Copy link
Owner

Thank you very much for testing this!

What do you think a fitting solution is?

Not sure. I might be mistaken, but I don't think that it is a high priority to increase the target version. I'd rather focus my efforts some place else for the time being.

@tegridyfarmer
Copy link
Author

With Android 16 being finalized in the coming months is it maybe better to wait for the 36 sdk to come out, so that does not have to be addressed later?

https://www.androidauthority.com/android-16-release-date-3495817/

@johannesjo
Copy link
Owner

With Android 16 being finalized in the coming months is it maybe better to wait for the 36 sdk to come out, so that does not have to be addressed later?

Yes, lets do it like this.

@tegridyfarmer tegridyfarmer closed this by deleting the head repository Feb 22, 2025
@tegridyfarmer
Copy link
Author

I'll open a new PR when Android 16 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants