Prevent page from closing when pressing back in task detail panel #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `window.history` to keep the panel as another history state. When the panel is destroyed the history entry is deleted.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Looks promising! What is missing for the PR to leave the WIP status? |
|
Mostly not sure if there are any tests that should be added, this code does accomplish the functionality at least as I tested it on my computer and Android Studio. Also, not sure if the use of Anyway I don't think there is a need to keep it as WIP anymore. |
|
Thank you! I think it works really nicely! I am very happy about the new behavior! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents page from changing or app from closing upon pressing the back button (in android or with a mouse). This is done by using
window.historyto keep the panel as another history state. When the panel is destroyed, the history entry is deleted. And when going back in history is attempted, the panel closes itself.Issues Resolved
#3607
Check List