Check for supported events first, send SND_BELL as fallback #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device might not support SND_TONE events, so check it and print an error if this event type is not supported. Signed-off-by: Bastian Krause <[email protected]>
The gpio-beeper driver does not support SND_TONE, but SND_BELL. So send that instead if SND_TONE is not supported. Signed-off-by: Bastian Krause <[email protected]>
|
Due to #11 (comment), I will evaluate this and pick it up over at https://github.com/spkr-beep/beep. |
|
Are there well known device names for the |
ndim
added a commit
to spkr-beep/beep
that referenced
this pull request
Mar 8, 2020
The gpio-beeper driver does not support SND_TONE, but SND_BELL. So we send SND_BELL instead when SND_TONE is not supported. Adapted the pull request from Bastian Krause <[email protected]> from johnath#17 for spkr-beep. No well-known devices names for those devices are known, so we cannot try them by default.
Yep, it's |
ndim
added a commit
to spkr-beep/beep
that referenced
this pull request
Mar 10, 2020
The gpio-beeper driver does not support SND_TONE, but SND_BELL. So we send SND_BELL instead when SND_TONE is not supported. Adapted the pull request from Bastian Krause <[email protected]> from johnath#17 for spkr-beep. No well-known devices names for those devices are known, so we cannot try them by default.
ndim
added a commit
to spkr-beep/beep
that referenced
this pull request
Mar 10, 2020
The gpio-beeper driver does not support SND_TONE, but SND_BELL. So we send SND_BELL instead when SND_TONE is not supported. Adapted the pull request from Bastian Krause <[email protected]> from johnath#17 for spkr-beep. No well-known devices names for those devices are known, so we cannot try them by default. Closes: #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device might not support
SND_TONEevents, so check it and print an error if this event type is not supported.The gpio-beeper driver does not support
SND_TONE, butSND_BELL. So send that instead ifSND_TONEis not supported.