Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the named properties object for global #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement the named properties object for global #25

wants to merge 1 commit into from

Conversation

Sebmaster
Copy link
Member

@Sebmaster Sebmaster commented May 22, 2016 •
edited
Loading

TODO:

  • [LegacyUnenumerableNamedProperties]

domenic
domenic reviewed May 22, 2016
View reviewed changes
lib/constructs/interface.js Outdated
this.str += `
var ${this.name}Properties = new Proxy(${this.name}PropertiesConstructor.prototype, {
get(target, key) {
if (key in this) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be looking at the target, not this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've only paid attention to the prototype chain for now.

@domenic
Copy link
Member

domenic commented May 22, 2016

In general we need to run tests to make sure adding a proxy in the global prototype chain doesn't massively slow down everything.

The best benchmark I've found is to clone tc39/ecma262, do time node_modules/.bin/ecmarkup--verbose spec.html out/index.html, then force install a version of jsdom patched appropriately, and do it again. We shouldn't regress by more than a few seconds.

@Sebmaster Sebmaster force-pushed the feature/named-properties-object branch from c6e320e to 41d76d6 Compare June 11, 2016 11:16
@Sebmaster Sebmaster force-pushed the feature/named-properties-object branch from 166a630 to 3269ada Compare September 29, 2016 03:47
@Sebmaster Sebmaster force-pushed the feature/named-properties-object branch from 3269ada to 15e36d3 Compare February 28, 2017 02:42
@Sebmaster Sebmaster force-pushed the feature/named-properties-object branch from 15e36d3 to 851b047 Compare February 28, 2017 02:44
@ExE-Boss ExE-Boss mentioned this pull request Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sebmaster @domenic