Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline integration #83

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Baseline integration #83

merged 10 commits into from
Oct 2, 2023

Conversation

Egorrko
Copy link
Contributor

@Egorrko Egorrko commented Sep 15, 2023

This PR experiment is about generating and checking errors using the baseline file.

I understand that I haven't written the tests yet. Please rate this PR as an idea.

@jsh9
Copy link
Owner

jsh9 commented Sep 15, 2023

Hi @Egorrko , I think this is a cool idea. Please feel free to keep experimenting on this branch.

@Egorrko
Copy link
Contributor Author

Egorrko commented Sep 17, 2023

@jsh9 I think this PR is ready for your viewing and testing

@jsh9
Copy link
Owner

jsh9 commented Sep 17, 2023

Hi @Egorrko , would you mind writing some instructions on how to use this feature? You can reply here and I'll put them into README myself. Thanks!

@Egorrko
Copy link
Contributor Author

Egorrko commented Sep 17, 2023

Sorry about my CI linting problems
I can't reproduce this tox environment to check all this problems myself

@@ -209,6 +237,7 @@ def validateStyleValue(
),
is_eager=True,
callback=injectDefaultOptionsFromUserSpecifiedTomlFilePath,
default='pyproject.toml',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at this change:
I think it could be useful for most of users

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'm sorry but I don't quite understand your comment here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that now for most of the projects to keep the pyproject.toml file in the root is the standard

@jsh9
Copy link
Owner

jsh9 commented Sep 17, 2023

Sorry about my CI linting problems I can't reproduce this tox environment to check all this problems myself

That's fine. I know what those CI errors are from and I can fix them for you.

What I don't quite know is: as a user, how would I use the new feature that you are adding here.

@Egorrko
Copy link
Contributor Author

Egorrko commented Sep 17, 2023

@jsh9
How to use the baseline parameter:
First, you need to generate a baseline file.
Use the --generate-baseline True key, and the --baseline <PATH> key (or add the string baseline ="pydoclint-baseline.txt" to your config file).
After that, your file will be created, and it will contain all the current errors in the project and you will be able to include it in the current CI.
All old errors will be ignored, and any new error will be displayed.
You need to run pydoclint as usual - in check mode.

@Egorrko
Copy link
Contributor Author

Egorrko commented Sep 17, 2023

@jsh9
Copy link
Owner

jsh9 commented Sep 17, 2023

@jsh9 How to use the baseline parameter: First, you need to generate a baseline file. Use the --generate-baseline True key, and the --baseline <PATH> key (or add the string baseline ="pydoclint-baseline.txt" to your config file). After that, your file will be created, and it will contain all the current errors in the project and you will be able to include it in the current CI. All old errors will be ignored, and any new error will be displayed. You need to run pydoclint as usual - in check mode.

Thanks!

I'll try it out tomorrow and then I'll write these instructions into README and publish a new version.

@RastaDill
Copy link

Yea. Thats cool idea. @jsh9 did you manage to view the instructions?

@jsh9
Copy link
Owner

jsh9 commented Sep 21, 2023

Hi @RastaDill and @Egorrko , I haven't had a chance to get to it these past few days -- sorry! Swamped by other things. I'll have a chance to get to it tomrorow.

@Egorrko
Copy link
Contributor Author

Egorrko commented Sep 26, 2023

@jsh9 Hello :)
Any news?
Maybe I should edit README.md independently, by analogy with previous PR?

@jsh9
Copy link
Owner

jsh9 commented Sep 28, 2023

Hi @Egorrko , sorry I was still too busy to actually test it and write README. If you'd like to contribute to this PR, please feel free to do so. Thank you!

@jsh9 jsh9 merged commit 0474b26 into jsh9:main Oct 2, 2023
13 checks passed
@jsh9
Copy link
Owner

jsh9 commented Oct 2, 2023

Hi @Egorrko , thanks so much for adding the documentation. I've read through them and made some tweaks. I just merged the MR and I'll publish the new version now.

@jsh9
Copy link
Owner

jsh9 commented Oct 2, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants