-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseline integration #83
Conversation
Hi @Egorrko , I think this is a cool idea. Please feel free to keep experimenting on this branch. |
54c4b26
to
b0b5411
Compare
@jsh9 I think this PR is ready for your viewing and testing |
Hi @Egorrko , would you mind writing some instructions on how to use this feature? You can reply here and I'll put them into README myself. Thanks! |
Sorry about my CI linting problems |
@@ -209,6 +237,7 @@ def validateStyleValue( | |||
), | |||
is_eager=True, | |||
callback=injectDefaultOptionsFromUserSpecifiedTomlFilePath, | |||
default='pyproject.toml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at this change:
I think it could be useful for most of users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I'm sorry but I don't quite understand your comment here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that now for most of the projects to keep the pyproject.toml
file in the root is the standard
That's fine. I know what those CI errors are from and I can fix them for you. What I don't quite know is: as a user, how would I use the new feature that you are adding here. |
@jsh9 |
Thanks! I'll try it out tomorrow and then I'll write these instructions into README and publish a new version. |
Yea. Thats cool idea. @jsh9 did you manage to view the instructions? |
Hi @RastaDill and @Egorrko , I haven't had a chance to get to it these past few days -- sorry! Swamped by other things. I'll have a chance to get to it tomrorow. |
@jsh9 Hello :) |
Hi @Egorrko , sorry I was still too busy to actually test it and write README. If you'd like to contribute to this PR, please feel free to do so. Thank you! |
Hi @Egorrko , thanks so much for adding the documentation. I've read through them and made some tweaks. I just merged the MR and I'll publish the new version now. |
0.3.3 published: https://github.com/jsh9/pydoclint/releases/tag/0.3.3 |
This PR experiment is about generating and checking errors using the baseline file.
I understand that I haven't written the tests yet. Please rate this PR as an idea.