New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csv2json only returns a stream and not the JSON #38

Open

KunalBurangi opened this issue Oct 25, 2023 · 1 comment · May be fixed by #37

Assignees

Collaborator

KunalBurangi commented Oct 25, 2023 •

edited

Loading

Hi @julien-f ,
I have created a pull request with some code changes.
PR/37

one problem I saw was that the function csv2json only returns a stream and not the JSON, so creating a JSON object becomes very complicated even after using the module..
Now it directly returns JSON data..
Added an example.js file
Added a test file...
Added jsonDoc
What do you think about it ?
If you think this is a good idea then i ll modify this to support cli as well

KunalBurangi linked a pull request

that will close this issue

chore: added some changes and refactoring to code #37

Open

KunalBurangi assigned julien-f and KunalBurangi and unassigned julien-f

Collaborator Author

KunalBurangi commented Oct 28, 2023

@julien-f can you please suggest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment