New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added some changes and refactoring to code #37

Open

KunalBurangi wants to merge 4 commits into master from refactor/minor_improvements

Collaborator

KunalBurangi commented Oct 25, 2023 •

edited

Loading

Hi @julien-f ,
I have created a pull request with some code changes.

one problem I saw was that the function csv2json only returns a stream and not the JSON, so creating a JSON object becomes very complicated even after using the module..
Now it directly returns JSON data..
Added an example.js file
Added a test file...
Added jsonDoc
What do you think about it ?


          chore: added some changes and refactoring to code

b4a9d6d

KunalBurangi mentioned this pull request

csv2json only returns a stream and not the JSON #38

Open

kbur added 2 commits

October 26, 2023 10:45


          chore: adjusted cli.js to work with new setup

2d31cc4


          chore: minor chanage

1ce1fb8

KunalBurangi linked an issue

that may be closed by this pull request

csv2json only returns a stream and not the JSON #38

Open


          chore: readme changes

6088a35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet