Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.4 deprecation: Implicitly marking parameter as nullable is deppricated #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marksgerasimovs
Copy link

@marksgerasimovs marksgerasimovs commented Feb 7, 2025

With php 8.4 deprecation warnings appear
marking parameter %s as nullable is deprecated, the explicit nullable type must be used instead
To set nullable type had to bump min. required php version to 7.1 though

List of common tasks a pull request require complete

  • Changelog entry is added or the pull request don't alter library's functionality

@marksgerasimovs marksgerasimovs marked this pull request as ready for review February 7, 2025 17:44
@ChagarinIvan
Copy link

Also waiting for these changes.

@DeepDiver1975
Copy link
Collaborator

This change would require a major release ...

Copy link
Collaborator

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the GitHub workflow configuration - thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants