Skip to content
This repository has been archived by the owner on Aug 20, 2019. It is now read-only.

Place a sell order #46

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Place a sell order #46

wants to merge 9 commits into from

Conversation

jvandenaardweg
Copy link
Owner

@jvandenaardweg jvandenaardweg commented Feb 21, 2018

Created PR for issue: #3

@adis-me already did some work on it, that's awesome! Still a few major things for this one:

  • Use correct sell flow (see below)
  • Use correct summary data (fee calculation etc..)
  • Ability to change balance and trading pair from the sell modal if the user already selected those options
  • Test if sell order works
  • Write tests for sell modal

I think this is a correct flow to use:

  1. User presses [New sell order]
  2. System shows modal with option to search/select coin in balance
  3. User searches/selects a coin in his balance
  4. System shows option for trading pair
  5. User selects to what pair he wants to trade: BTC, ETH or USDT (depending on exchange pairs)
  6. System shows sell modal
  7. User places sell order
  8. System closes modal and shows new order in Orders page

@jvandenaardweg jvandenaardweg force-pushed the ac-3-place-a-sell-order branch from 700f6ea to 0360ac9 Compare March 2, 2018 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants