Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bevy 0.15 #255

Open
wants to merge 6 commits into
base: blenvy
Choose a base branch
from
Open

Conversation

ptsd
Copy link

@ptsd ptsd commented Oct 24, 2024

No description provided.

Copy link

@spacekookie spacekookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes the build issues in my game with bevy 0.15 and the blenvy plugin. There are however some compilation issues in the examples (that might be unrelated?) I don't understand

@ptsd ptsd force-pushed the blenvy-bevy-0.15 branch 2 times, most recently from 9dbfb40 to 3fd2784 Compare December 31, 2024 15:22
@ptsd
Copy link
Author

ptsd commented Dec 31, 2024

Apologies forgot I'd done this and left it in draft.

@ptsd ptsd marked this pull request as ready for review December 31, 2024 15:43
@ptsd
Copy link
Author

ptsd commented Dec 31, 2024

There are however some compilation issues in the examples (that might be unrelated?) I don't understand.

The examples seem to compile for me, there are some issues related to asset loading if you try and run them outside of their directory.

i.e.

~/Projects/misc/Blenvy                                                                                                                                                                                                                                                                                                   
❯ cargo run --package blenvy_animation_example --bin blenvy_animation_example
   Compiling blenvy v0.1.0-alpha.2 (/Users/ptsd/Projects/misc/Blenvy/crates/blenvy)
   Compiling blenvy_animation_example v0.0.1 (/Users/ptsd/Projects/misc/Blenvy/examples/animation)
    Finished `dev` profile [optimized + debuginfo] target(s) in 11.32s
     Running `target/debug/blenvy_animation_example`
2024-12-31T15:53:56.537742Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon R9 M290X", vendor: 0, device: 0, device_type: DiscreteGpu, driver: "", driver_info: "", backend: Metal }
2024-12-31T15:53:57.125273Z  INFO bevy_winit::system: Creating new window "App" (0v1#4294967296)
thread 'main' panicked at crates/blenvy/src/registry/export_types.rs:17:51:
should have created schema file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `blenvy::registry::export_types::export_types`!
Encountered a panic in system `bevy_app::main_schedule::Main::run_main`!

vs:

~/Projects/misc/Blenvy                                                                                                                                                                                                                                                                                     
❯ cd examples/animation/
~/Projects/misc/Blenvy/examples/animation                                                                                                                                                                                                                                                                            
❯ cargo run --package blenvy_animation_example --bin blenvy_animation_example
    Finished `dev` profile [optimized + debuginfo] target(s) in 0.33s
     Running `/Users/ptsd/Projects/misc/Blenvy/target/debug/blenvy_animation_example`
2024-12-31T15:55:43.808037Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon R9 M290X", vendor: 0, device: 0, device_type: DiscreteGpu, driver: "", driver_info: "", backend: Metal }
2024-12-31T15:55:44.388719Z  INFO bevy_winit::system: Creating new window "App" (0v1#4294967296)
2024-12-31T15:55:44.905964Z  INFO blenvy::registry::export_types: Done exporting registry schema
...

Looks like this is fixed by #256 🤷‍♀️

@vveisard
Copy link

I hate to beg for merge requests, but could we get a review/ approval? @spacekookie @kaosat-dev

Thanks!

@TGRCdev
Copy link

TGRCdev commented Jan 21, 2025

Theres a few issues with the Blender plugin on this branch that I ran into while using it myself.

Both of these commits are free for cherry-picking/copying.

@kaosat-dev
Copy link
Owner

Thanks a lot for this PR @ptsd !
Very sorry for the lack of replies until now. I'll take a look at the PR and see how I can get it merged asap.
@TGRCdev good findings, that should make fixing those issues easier , Thanks !

@kaosat-dev
Copy link
Owner

Btw @ptsd , would you be ok with rebasing this PR if I merge the other smaller PRs that preceded it ?
I am going over things one by one and I think most of the smaller PRs should not have a significant impact on the Bevy 0.15 compatibility

@ptsd
Copy link
Author

ptsd commented Jan 30, 2025

Btw @ptsd , would you be ok with rebasing this PR if I merge the other smaller PRs that preceded it ? I am going over things one by one and I think most of the smaller PRs should not have a significant impact on the Bevy 0.15 compatibility

No problem at all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants