Skip to content

Commit

Permalink
chore: wip -- back to doc not found, NODE_ENV was the culprit
Browse files Browse the repository at this point in the history
  • Loading branch information
kasir-barati committed May 16, 2024
1 parent 6c9c4b7 commit fce124a
Show file tree
Hide file tree
Showing 19 changed files with 5 additions and 1,155 deletions.
2 changes: 2 additions & 0 deletions apps/frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
ARG NODE_ENV=production

# This file is generated by Nx.
#
# Build the docker image with `nx build:docker frontend`.
Expand Down
5 changes: 2 additions & 3 deletions apps/frontend/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@

## Building NextJS app

Run `nx build:docker frontend` to build it in production mode
Run `nx build:docker frontend --configuration=dev` to build it in development mode:

- Run `nx build:docker frontend` to build it in production mode
- Run `nx build:local frontend` to build it in your own system
- It won't utilizes caching mechanism during building docker image

**Note**: Do not use these two configuration options in your `next.config.js`, since by doing that it is gonna make it harder for us to build our app: `output: 'export'` and `distDir: '../../dist/apps/frontend'`. Better to follow the their [official docs](https://nextjs.org/docs/app/building-your-application/deploying#docker-image).
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"build:local": {
"executor": "nx:run-commands",
"options": {
"commands": ["npx env-cmd -f .env nx build frontend"]
"commands": ["NODE_ENV=production nx build frontend"]
}
},
"build:docker": {
Expand Down
34 changes: 0 additions & 34 deletions apps/my-new-app/.eslintrc.json

This file was deleted.

6 changes: 0 additions & 6 deletions apps/my-new-app/index.d.ts

This file was deleted.

11 changes: 0 additions & 11 deletions apps/my-new-app/jest.config.ts

This file was deleted.

5 changes: 0 additions & 5 deletions apps/my-new-app/next-env.d.ts

This file was deleted.

22 changes: 0 additions & 22 deletions apps/my-new-app/next.config.js

This file was deleted.

9 changes: 0 additions & 9 deletions apps/my-new-app/project.json

This file was deleted.

Empty file removed apps/my-new-app/public/.gitkeep
Empty file.
Binary file removed apps/my-new-app/public/favicon.ico
Binary file not shown.
11 changes: 0 additions & 11 deletions apps/my-new-app/specs/index.spec.tsx

This file was deleted.

3 changes: 0 additions & 3 deletions apps/my-new-app/src/app/api/hello/route.ts

This file was deleted.

Loading

0 comments on commit fce124a

Please sign in to comment.