-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lfx pre test adding expression syntax rules and refine test cases #10
Conversation
You can refer the following docs, impls and avoid submitting syntax unrelated to KCL. |
Sorry, mistakenly overlooked that |
Just to confirm @Peefy |
Yes. Different expressions and syntax are added to |
Signed-off-by: Vishal <[email protected]>
Signed-off-by: Vishal <[email protected]>
Hello @Daksh-10 , do you mean the tree-sitter grammar for the KCL string? https://github.com/kcl-lang/tree-sitter-kcl/blob/main/grammar.js#L660 If you want to know how tree-sitter grammar syntax and principle, you can refer https://tree-sitter.github.io/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
In the
test/corpus
I did add test cases for unary expressions, conditonal expressions and slice expressions.3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: