Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expr-syntax rules and expr-tests #14

Merged
merged 8 commits into from
May 24, 2024

Conversation

shruti2522
Copy link
Contributor

@shruti2522 shruti2522 commented May 22, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

added expr:

  • null_coalesce operator (expr1 or expr2).
  • smoke_expr
  • nonstring_literal_expr
  • string_literal_expr
  • number_bin_suffix_expr
  • config_expr
  • bracket_expr
  • braces_expr

added tests for:

  • null coalesce expression
  • paren expression
  • boolean expression
  • not operator
  • lambda expression
  • comparison operators
  • smoke expr
  • nonstring_literal_expr
  • string_literal_expr
  • number_bin_suffix_expr
  • config_expr
  • bracket_expr
  • braces_expr

Signed-off-by: shruti2522 <[email protected]>
Signed-off-by: shruti2522 <[email protected]>
Signed-off-by: shruti2522 <[email protected]>
@shruti2522 shruti2522 changed the title feat: add expr-tests and null_coalesce expr feat: add syntax rules and expr-tests May 23, 2024
Signed-off-by: shruti2522 <[email protected]>
Signed-off-by: shruti2522 <[email protected]>
Signed-off-by: shruti2522 <[email protected]>
@shruti2522 shruti2522 changed the title feat: add syntax rules and expr-tests feat: add expr-syntax rules and expr-tests May 23, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 3983ce5 into kcl-lang:main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants