Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Fine-Tuning section for GitHub runner scaler #1535

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

silviu-dinu
Copy link
Contributor

Improving GitHub scaler documentation by adding Fine-Tuning section and highlighting current limitations.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #6519

@silviu-dinu silviu-dinu requested a review from a team as a code owner February 12, 2025 10:04
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for keda ready!

Name Link
🔨 Latest commit a4ba77b
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/67ac909a2f51d700088ff370
😎 Deploy Preview https://deploy-preview-1535--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, one minor nit, from this version is it not clear what limit has the current implementation (vs the older one has 30).

Could you please update this?

@silviu-dinu
Copy link
Contributor Author

This is great, one minor nit, from this version is it not clear what limit has the current implementation (vs the older one has 30).

Could you please update this?

@zroubalik Thanks! That's a good point. It's changed now.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zroubalik zroubalik merged commit a3ac44b into kedacore:main Feb 12, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants