Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Workflow Secrets #3620

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Mubashirshariq
Copy link
Contributor

@Mubashirshariq Mubashirshariq commented Feb 21, 2025

Closes #3554

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented Feb 21, 2025

@Mubashirshariq is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 21, 2025
@Mubashirshariq Mubashirshariq marked this pull request as draft February 21, 2025 18:29
@talboren talboren changed the title Feat:Added secrets to workflows feat: Workflow Secrets Feb 23, 2025
Comment on lines 874 to 877
@router.post(
"/{workflow_id}/new-secret",
description="Write a new secret or update existing secret for a workflow",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@router.post(
"/{workflow_id}/new-secret",
description="Write a new secret or update existing secret for a workflow",
)
@router.post(
"/{workflow_id}/secrets",
description="Write a new secret or update existing secret for a workflow",
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Matvey-Kuk Matvey-Kuk requested a review from talboren February 24, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[βž• Feature]: Workflow Secrets
2 participants