feat: assert and fail mvn test if the keploy test fails #169
Conversation
Signed-off-by: Sarthak160 <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| </execution> | ||
| </executions> | ||
| </plugin> | ||
|
|
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck> reported by reviewdog 🐶
Line has trailing spaces.
| @@ -35,7 +35,7 @@ public class Keploy { | |||
| private static long userCommandPid = 0; | |||
|
|
|||
| private static String jacocoCliPath = ""; | |||
|
|
|||
| private static String currentTestRunId; | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> reported by reviewdog 🐶
Missing a Javadoc comment.
| @@ -477,9 +477,24 @@ public static void runTests(String jarPath) { | |||
| } | |||
| stopUserApplication(); | |||
| } | |||
| logger.debug("All test sets executed and stoping the ebpf hooks" ); | |||
| logger.debug("All test sets executed and stopping the ebpf hooks" ); | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.ParenPadCheck> reported by reviewdog 🐶
')' is preceded with whitespace.
| } | ||
| } catch (InterruptedException e) { | ||
| System.err.println("Error waiting for test run completion: " + e.getMessage()); | ||
| logger.error("Error waiting for test run completion: " + e.getMessage()); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 80 characters (found 85).
Signed-off-by: Sarthak160 <[email protected]>
| @@ -35,8 +35,11 @@ public class Keploy { | |||
| private static long userCommandPid = 0; | |||
|
|
|||
| private static String jacocoCliPath = ""; | |||
|
|
|||
| private static String currentTestRunId; | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> reported by reviewdog 🐶
Missing a Javadoc comment.
| private static String jacocoAgentPath = ""; | ||
| private static Boolean isFailed = false; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> reported by reviewdog 🐶
Missing a Javadoc comment.
| private static String jacocoAgentPath = ""; | ||
| private static Boolean isFailed = false; | ||
| private static List<String> failedTestSets = new ArrayList<>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> reported by reviewdog 🐶
Missing a Javadoc comment.
| private static String jacocoAgentPath = ""; | ||
| private static Boolean isFailed = false; | ||
| private static List<String> failedTestSets = new ArrayList<>(); | ||
|
|
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck> reported by reviewdog 🐶
Line has trailing spaces.
|
|
||
| // Check the test run status after all tests are executed | ||
|
|
||
| // change to each test run and at last if any of the test failed then throw an |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 80 characters (found 86).
| // TestRunStatus status = FetchTestSetStatus(currentTestRunId); | ||
| // Throw an exception if the status is FAILED | ||
| if (isFailed) { | ||
| org.junit.jupiter.api.Assertions.fail("Test run failed for test sets : " + failedTestSets); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 80 characters (found 103).
|
@gouravkrosx Please run this once at your end, So that I can merge and release . |
Signed-off-by: Sarthak160 <[email protected]>
| logger.info("Test run failed"); | ||
| isFailed = true; | ||
| failedTestSets.add(currentTestRunId); | ||
|
|
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck> reported by reviewdog 🐶
Line has trailing spaces.
Related Issue
Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Type of change
How did you test your code changes?
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)