Some minor cleanup

CMakeLists.txt

@@ -4,9 +4,6 @@ project(lox_cpp)
 # Compile commands json generation
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 
-# C++ standard
-set(CMAKE_CXX_STANDARD 23)
-
 # CCACHE Setup
 if (CCACHE_FOUND)
     message(CCACHE_FOUND)

src/CMakeLists.txt

@@ -1,3 +1,6 @@
+# C++ standard
+set(CMAKE_CXX_STANDARD 23)
+
 add_library(lox_compiler STATIC
         chunk.cpp
         virtual_machine.cpp

src/heap.cpp

@@ -134,6 +134,10 @@ auto Heap::insertAtHead(Object* new_node) -> void
 auto Heap::collectGarbage() -> void
 {
     GCDebugLog("Begining garbage collection");
+    /*
+     * TODO
+     */
+    GCDebugLog("Garbage collection complete");
 }
 
 auto Heap::freeObject(Object* object) -> void

src/object.h

@@ -22,7 +22,6 @@ enum class ObjectType {
 };
 
 struct Object {
-public:
     [[nodiscard]] auto GetType() const -> ObjectType
     {
         return type;
@@ -33,14 +32,15 @@ struct Object {
         marked = true;
     }
 
-protected:
     Object() = delete;
+
     Object(ObjectType type)
         : type(type)
     {
     }
+
     friend class Heap;
-    ObjectType type;
+    ObjectType type {};
     Object* next = nullptr;
     bool marked = false;
 };
@@ -58,9 +58,9 @@ struct FunctionObject : public Object {
         : Object(ObjectType::FUNCTION)
     {
     }
-    std::string function_name;
+    std::string function_name {};
     uint32_t arity {};
-    Chunk chunk;
+    Chunk chunk {};
     uint16_t upvalue_count {};
 };
 
@@ -70,7 +70,7 @@ struct NativeFunctionObject : public Object {
         : Object(ObjectType::NATIVE_FUNCTION)
     {
     }
-    NativeFunction native_function;
+    NativeFunction native_function { nullptr };
 };
 
 struct UpvalueObject : public Object {
@@ -107,15 +107,15 @@ struct UpvalueObject : public Object {
     }
 
 private:
-    std::variant<Value, uint16_t> m_data;
+    std::variant<Value, uint16_t> m_data {};
 };
 
 struct ClosureObject : Object {
     ClosureObject()
         : Object(ObjectType::CLOSURE)
     {
     }
-    std::vector<UpvalueObject*> upvalues;
+    std::vector<UpvalueObject*> upvalues {};
     FunctionObject const* function = nullptr;
 };
 #endif // LOX_CPP_OBJECT_H

src/value_formatter.h

@@ -3,7 +3,6 @@
 #ifndef LOX_CPP_VALUE_FORMATTER_H
 #define LOX_CPP_VALUE_FORMATTER_H
 
-#include <exception>
 #include <fmt/core.h>
 
 #include "object.h"

tests/CMakeLists.txt

@@ -1,3 +1,6 @@
+# C++ standard
+set(CMAKE_CXX_STANDARD 23)
+
 add_executable(test_compiler test_compiler.cpp test_virtual_machine.cpp main.cpp)
 target_link_libraries(test_compiler gtest_main lox_compiler fmt)
 add_test(NAME test_compiler COMMAND test_compiler)