Implemented invoice search box in latest invoice section. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre
reviewed
Sep 19, 2023
|
|
||
| function searchInvoices () { | ||
| var invoiceSearch = document.getElementById('invoice-search').value; | ||
| table.search( invoiceSearch ).draw(); |
There was a problem hiding this comment.
- Is this performing only client-side search (in datatables)? What happens when there are multiple pages of invoices?
- Is this performing a full table search or just search on a specific column? Would search for "15" match both the invoice number and the invoice amount?
There was a problem hiding this comment.
Hi Pierre,
- We will be doing client-side search only as we are utilizing Datatable Search() API. Also, we will search from multiple pages and not from a single page.
- We are performing a search only on the Number column and not full table search. So if we are searching for 15, it will give search results based on invoice number and not other columns.
|
As invoice specific search feature is already implemented in killbill-admin-ui closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are introducing a search box in Latest Invoices so that users can easily search an invoice by number