Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 397 Sync with killbill-client #398

Conversation

tungleduyxyz
Copy link
Contributor

@tungleduyxyz tungleduyxyz force-pushed the issue_397_sync_with_killbill_client branch 3 times, most recently from bb7eaa7 to 7ceec80 Compare April 25, 2024 06:19
@tungleduyxyz tungleduyxyz force-pushed the issue_397_sync_with_killbill_client branch from 7ceec80 to ca32dda Compare April 25, 2024 07:01
Copy link
Contributor

@reshmabidikar reshmabidikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a high-level look and it looks good. Before merging, I think we should do a round of testing to ensure that there are no regressions.

@reshmabidikar
Copy link
Contributor

I did a round of Kaui testing with these changes and it all looks good. Test results are documented in this test report. PR is good to be merged.

@reshmabidikar reshmabidikar merged commit 4944870 into killbill:master Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants