locker: naive lock implementation on Redis #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the simplest implementation on top of our current locking framework. We can probably do better though as there are two types of retries happening (redisson tryLock and ours). Note that this would now pull the redisson jar by default. Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
pierre
force-pushed
the
master
branch
7 times, most recently
from
be7aeaa
to
694ba52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest implementation on top of our current locking framework.
We can probably do better though as there are two types of retries happening
(redisson
tryLockand ours). We should think about it before merging.Note that this would now pull the redisson jar by default.