Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root installation, update dependencies & more default repositories #101

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

machiav3lli
Copy link

This PR include:

  • Updating the dependencies, Kotlin, Gradle and AGP
  • Raising target- and compileSDK to 31 and add needed permissions
  • Add root installation method
  • Add 23 default repository
  • True black as background in dark theme

@Madis0
Copy link

Madis0 commented Sep 17, 2021

Are you sure the owner agrees with all your additions and it is easy to discern them? It might be a better idea to split the features into different PRs

@machiav3lli
Copy link
Author

Are you sure the owner agrees with all your additions and it is easy to discern them? It might be a better idea to split the features into different PRs

In #102 I try to explain my position to the maintaining of the project. Eventually I'd consider those changes as a first step in direction co-maintaining the project. If such is not wished/wanted I'd be starting an independent fork.

@RickyM7
Copy link

RickyM7 commented Sep 17, 2021

@machiav3lli If you are really going to continue this project in a new fork, please talk here, as I want to follow this project, after all Foxy Droid is the best F-Droid client in my opinion.

@NoahAndrews
Copy link

NoahAndrews commented Sep 23, 2021

Note that adding a bunch of new repositories to the defaultRepositories list is not good enough to make them available to existing users, because that list only gets referenced when the database is first created (not just updated):

if (helper.created) {
for (repository in Repository.defaultRepositories) {
RepositoryAdapter.put(repository)
}

New code needs to be added that is capable of adding default repositories only if they aren't already in the database (including if they are in the database, but marked as deleted).

BTW, I'm the developer of a sort of Foxy Droid fork myself. While the Driver Hub Software Manager has very different goals from Foxy Droid, I have implemented some functionality (such as updating all apps with a single button press) that could be useful to Foxy Droid users.

@3504k
Copy link

3504k commented Sep 24, 2021

For the love of FOSS and all things holy in this world, I pray in the name of Izzy to all the open source gods to please make a usable fork of this project.

@another-sapiens
Copy link

@3504k Droid-ify!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants