Update settings for django-allauth #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhelba
commented
Jan 31, 2025
| # Quality of life improvements, but may not work if the browser is closed | ||
| ACCOUNT_SESSION_REMEMBER = True | ||
| ACCOUNT_LOGIN_ON_EMAIL_CONFIRMATION = True | ||
| ACCOUNT_LOGIN_ON_PASSWORD_RESET = True | ||
|
|
||
| # These will permit GET requests to mutate the user state, but significantly improve usability |
There was a problem hiding this comment.
I now feel more concerned about the security implications of allowing this. I think the default of requiring a user to click a confirmation button isn't too burdensome.
There was a problem hiding this comment.
@danlamanna I'm open to other perspectives.
As it stands, this directly makes the site vulnerable to CSRF for these operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.