Add localtime template tag #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhelba
requested changes
Jul 13, 2022
There was a problem hiding this comment.
Can you rebase this branch? CI was broken previously.
Regarding:
This requires adding the time-elements script (github/time-elements) to the pages this is used on.
At a minimum, this needs to be documented in the localtime docstring.
However, I think we need to provide more support for downstreams to use this library. How about a second template tag, which could be used within the page <head>, to add the appropriate <script>?
|
I'd love for this to be upstreamed and agree with @brianhelba 's suggestion of an additional template tag to include the JS. |
|
This is a working incantation for getting the library from CDN: <script type="module" src="https://cdn.jsdelivr.net/npm/@github/[email protected]/+esm"></script> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
This requires adding the time-elements script (https://github.com/github/time-elements) to the pages this is used on.