Return entire file object from DRF serializer #271
Conversation
|
@danlamanna Can you rebase this? It will be a little easier to think about with #278 in place. |
danlamanna
force-pushed
the
drf-serializer
branch
from
50ab99f to
5e9a243
Compare
|
@brianhelba done |
| @@ -29,6 +29,6 @@ def to_internal_value(self, data: Union[str, File]) -> str: # type: ignore[over | |||
|
|
|||
| # fields.S3FileField.save_form_data is not called by DRF, so the same behavior must be | |||
| # implemented here | |||
| internal_value = file_object.name | |||
There was a problem hiding this comment.
This change seems to violate the entire point of the above comment
fields.S3FileField.save_form_data is not called by DRF, so the same behavior must be implemented here
In particular, any FieldFile value will pass through the logic here https://github.com/django/django/blob/d4c5d2b52c897ccc07f04482d3f42f976a79223c/django/db/models/fields/files.py#L190-L202 . Changing this from a str to a S3PlaceholderFile will at least change how saves are handled.
In fact, I'm worried that this might be outright breaking the save process, but our tests just aren't specific enough to pick it up.
If you think this works, could we update the tests to add new assertions or cases to ensure that the intended save behavior (update the DB, don't touch the Storage) is still happending with this?
No description provided.