Skip to content

Commit

Permalink
Updated the testing_release.yml to use the JAVA 17.
Browse files Browse the repository at this point in the history
* Updated the README file to show that now our project requires the JAVA 17 instead of JAVA 11.
* Updated the pre-commit failed message to properly show the error information.
  • Loading branch information
MohitMaliDeveloper authored and kelson42 committed Aug 16, 2024
1 parent 9eebd2b commit 3f7d0f7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/testing_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
java-version: 11
java-version: 17
distribution: temurin

- name: Retrieve secrets to files
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ Studio](https://developer.android.com/studio).

If you prefer to build without Android Studio you must first set up
the Android SDK and then run the command: `./gradlew build ` from the
root directory of the project. The project requires `Java 11` to run,
Therefore set the `Gradle JDK` to `Java 11`.
root directory of the project. The project requires `Java 17` to run,
Therefore set the `Gradle JDK` to `Java 17`.

Kiwix Android is a multi-module project, in 99% of scenarios you will
want to build the `app` module in the `debug` configuration. If you
Expand Down
4 changes: 2 additions & 2 deletions team-props/git-hooks/pre-commit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ else
echo 1>&2 "Static analysis found violations and attempted to autofix, please commit these autoformat changes"
echo "
---------------------------IMPORTANT FOR KIWIX DEVELOPERS----------------------------------------------
If the build failed with '.../.gradle/daemon/8.0/custom/scr/customexample/info.json No File Found' then you do not have JAVA_HOME set to JDK11
Please make sure JAVA_HOME is set to JDK11
If the build failed with '.../.gradle/daemon/8.4/custom/scr/customexample/info.json No File Found' then you do not have JAVA_HOME set to JDK17
Please make sure JAVA_HOME is set to JDK17
---------------------------IMPORTANT FOR KIWIX DEVELOPERS----------------------------------------------"

exit 1
Expand Down

0 comments on commit 3f7d0f7

Please sign in to comment.