Fix refresh ZimFile details after download #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
- Coverage 37.71% 35.36% -2.35%
==========================================
Files 123 134 +11
Lines 6570 7730 +1160
==========================================
+ Hits 2478 2734 +256
- Misses 4092 4996 +904 ☔ View full report in Codecov by Sentry. |
kelson42
force-pushed
the
zim-file-details-refresh
branch
from
f30135e to
8316d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1112
Tested on iPhone and iPad. MacOS is not affected by the change, as it's within the
#if os(iOS)macro, plus we always display the unlink action on macOS.BEFORE:
zimdetail_before.mov
AFTER:
zimdetail_after.mov