Update README.md to correct broken donate images #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The images you linked to in your Dropbox account do not display on the README.md file. To generate a URL for embedding in Dropbox you have to use their Share button to generate a sharable URL. Since a non-owner can't do that, I went ahead and found the current Patreon logo (they changed logos since you linked it) and used that URL instead. I also added an image link to the same style of donate "tip jar" image you had used. I went ahead and manually set them to 100px height (you can adjust as needed), and since GitHub's Markdown doesn't allow image sizing I used HTML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The images you linked to in your Dropbox account do not display on the README.md file. To generate a URL for embedding in Dropbox you have to use their Share button to generate a sharable URL. Since a non-owner can't do that, I went ahead and found the current Patreon logo (they changed logos since you linked it) and used that URL instead.
I also added an image link to the same style of donate "tip jar" image you had used.
I went ahead and manually set them to 100px height (you can adjust as needed), and since GitHub's Markdown doesn't allow image sizing I used HTML.