Fix the shader wrapping function #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmamal
force-pushed
the
master
branch
3 times, most recently
from
eabe7d2 to
8743347
Compare
|
Thanks for this! I have incorporated it in this commit 9a1a636 I will also try to upstream it to https://github.com/stackgl/headless-gl. It looks like they are aware of the issue: stackgl#290 |
|
lol they fixed it already, the _wrapShader function is now empty: stackgl@5731a50#diff-6323d6e28ff21bcb05df2fd1def611809b1badf3af5977fd4a9933cc3d46428fL835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
WebGLRenderingContext._wrapShaderso the#versiondirective can work.The original
_wrapShaderfunction adds code to the start of the shader, making the #version directive unusable. The new function moves the#versiondirective to the start after the code is added.