Use orjson for faster JSONL output
#1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #1018 When generating a large (2GB) diff as JSON-Lines this takes 20-30% less time than the stdlib. It may be possible to use this in other places, but note that orjson doesn't support streaming encoding (iterencode), which means it is of limited utility where we're trying to stream JSON diffs of huge datasets. This change uses it for individual features in JSONL diffs only where the lack of iterencode() isn't a concern. orjson is MIT licensed.
olsen232
approved these changes
Nov 13, 2024
|
What is the indicative performance difference for #1018? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When generating a large (2GB) diff as JSON-Lines this takes 20-30% less
time than the stdlib.
It may be possible to use this in other places, but note that orjson
doesn't support streaming encoding (iterencode), which means it is of
limited utility where we're trying to stream JSON diffs of huge
datasets.
This change uses it for individual features in JSONL diffs only where
the lack of iterencode() isn't a concern.
orjson is {MIT, Apache 2} dual licensed.
Related links:
refs #1018
Checklist: