Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcb-aoi path errors and dependency conflicts resolved #171

Merged
merged 2 commits into from
Feb 6, 2025
Merged

pcb-aoi path errors and dependency conflicts resolved #171

merged 2 commits into from
Feb 6, 2025

Conversation

AryanNanda17
Copy link
Contributor

@AryanNanda17 AryanNanda17 commented Jan 5, 2025 •
edited
Loading

What type of PR is this?
/kind bug

/kind documentation

Fixes #170 #178

@kubeedge-bot kubeedge-bot added kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 5, 2025
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 5, 2025
@AryanNanda17 AryanNanda17 mentioned this pull request Jan 6, 2025
Closed
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
@AryanNanda17
Copy link
Contributor Author

I have fixed all the path errors.
Shoutout to @FuryMartin

@AryanNanda17 AryanNanda17 changed the title Resolved issue#170 Resolves issue#170 Jan 6, 2025
FuryMartin
FuryMartin approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@FuryMartin FuryMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes the path errors in the .yaml configs of PCB-AoI example.

The modification looks good to me.

@kubeedge-bot
Copy link
Collaborator

@FuryMartin: changing LGTM is restricted to collaborators

In response to this:

This PR fixes the path errors in the .yaml configs of PCB-AoI example.

The modification looks good to me.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AryanNanda17
Copy link
Contributor Author

AryanNanda17 commented Jan 7, 2025 •
edited
Loading

@MooreZheng @jaypume please have a look at this PR.
It is ready to be merged.

@MooreZheng MooreZheng requested review from hsj576 and removed request for jaypume January 8, 2025 03:06
@AryanNanda17
path errors corrected in pcb-aoi/singletask_learning_bench
2b80739 
Resolved conflicts in path errors

Signed-off-by: Aryan <[email protected]>

changed train_url to train_index, test_url to test_index

Signed-off-by: Aryan <[email protected]>

Corrected the path errors

Signed-off-by: Aryan <[email protected]>

fault detection renamed to fault_detection

Signed-off-by: Aryan Nanda <[email protected]>

Results saved to ./pcb-aoi/singletask_learning_bench

Signed-off-by: Aryan <[email protected]>
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
@MooreZheng
Copy link
Collaborator

The review meeting is scheduled on Feb 6th, 2025, together with #174. These PRs address the errors in the quick start guide of ianvs related to pcb-aoi/singletask_learning_example.

hsj576
hsj576 requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@hsj576 hsj576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no "_" between "fault" and "detection" in the path.

examples/pcb-aoi/incremental_learning_bench/fault_detection/testenv/testenv.yaml
@@ -13,7 +13,7 @@ testenv:
# metric name; string type;
name: "f1_score"
# the url address of python file
url: "./examples/pcb-aoi/incremental_learning_bench/testenv/f1_score.py"
url: "./examples/pcb-aoi/incremental_learning_bench/fault_detection/testenv/f1_score.py"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he path should be "./examples/pcb-aoi/incremental_learning_bench/fault detection/testenv/f1_score.py", and there is no "_" between "fault" and "detection".

@hsj576
Copy link
Member

hsj576 commented Feb 6, 2025

no "_" between "fault" and "detection" in the path.

I noticed that you renamed "fault detection" to "fault_detection." In that case, it is indeed unnecessary to remove the underscore from "fault_detection."

@hsj576
Copy link
Member

hsj576 commented Feb 6, 2025

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@FuryMartin
Copy link
Contributor

/lgtm

@kubeedge-bot
Copy link
Collaborator

@FuryMartin: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MooreZheng
MooreZheng reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This work helps to polish the quick start. It is important for newcomers to have the quick start executed normally. Overall it looks fine to me.

Besides, the change from train_url to train_index in "testenv.yaml" could be discussed in a new issue, because the field of this yaml need to be consistent with Sedna.

@MooreZheng
Copy link
Collaborator

/approve

@MooreZheng MooreZheng merged commit d18d9b6 into kubeedge:main Feb 6, 2025
12 of 13 checks passed
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FuryMartin, MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@AryanNanda17 AryanNanda17 mentioned this pull request Feb 6, 2025
Merged
@AryanNanda17 AryanNanda17 changed the title Resolves issue#170 pcb-aoi path errors and dependency conflicts resolved Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MooreZheng MooreZheng MooreZheng left review comments

@hsj576 hsj576 hsj576 requested changes

@FuryMartin FuryMartin Awaiting requested review from FuryMartin

Assignees

@MooreZheng MooreZheng

@hsj576 hsj576

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion on PCB-AOI Single-Task and Incremental Learning: Path Errors and Dependency Conflicts
5 participants
@AryanNanda17 @kubeedge-bot @MooreZheng @hsj576 @FuryMartin