Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI Issue #675: Right Sidebar in KubeEdge Version Blog Page is Too… #681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harshita9104
Copy link

Fix UI Issue #675

📌 Problem

  • The right sidebar in blog pages across all versions was too congested.
  • Scrollbar design was not user-friendly.

✅ Solution Implemented

  • Increased sidebar width slightly for better readability.
  • Improved styling for the scrollbar to make navigation smoother.
  • A more structured UI for readability and usability.

🔧 Files Changed

  • src/css/custom.css
  • docusaurus.config.js

🖼️ Screenshots

Before
image

After

image

📌 Fixes: #675
🚀 Ready for review!

@kubeedge-bot kubeedge-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 11, 2025
@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 11, 2025
…ested and Scrollbar Looks Bad

- Increased right sidebar width slightly to prevent content cutoff
- Adjusted sidebar item padding, font size, and spacing for better visibility
- Removed horizontal scrolling from the sidebar
- Ensured no overlap and perfect alignment
- Sidebar items now fully visible without left-right scrolling

Signed-off-by: harshita roonwal <[email protected]>
Signed-off-by: harshita91 <[email protected]>
@harshita9104 harshita9104 force-pushed the fix/sidebar-ui-issue-675 branch from 8a94240 to 8af9a27 Compare February 11, 2025 11:32
@kubeedge-bot kubeedge-bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 11, 2025
@harshita9104
Copy link
Author

Hello @Shelley-BaoYue , @anvithks ,
Kindly review the PR which enhances the sidebar of the blog page
The PR ensures :-
Increased sidebar width slightly for better readability.
Improved styling for the scrollbar to make navigation smoother.
A more structured UI for readability and usability.
Fixes #675

Kindly review the PR and suggest any changes!!

Thank you!!

@harshita9104
Copy link
Author

/assign @Shelley-BaoYue

@harshita9104
Copy link
Author

Fixes #675

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work looks good! Can the left sidebar be adjusted in width, or I think it would look better if it was narrower?

Signed-off-by: harshita91 <[email protected]>
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed.
You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshita9104
Copy link
Author

This work looks good! Can the left sidebar be adjusted in width, or I think it would look better if it was narrower?

Hello @Shelley-BaoYue , @anvithks
I have made the changes

After making changes according to your suggestions

image

Kindly review the PR !

Thank you so much !!

@TenzDelek
Copy link

hi @Shelley-BaoYue , I have an idea for this. what about we keep the blog content in a card format first then when a user click on it it should show this content. because currently the blog section looks more like a docs. how about we keep this work in the LFX as well?

like this->
Screenshot 2025-02-12 at 11 38 48 AM

@harshita9104
Copy link
Author

hi @Shelley-BaoYue , I have an idea for this. what about we keep the blog content in a card format first then when a user click on it it should show this content. because currently the blog section looks more like a docs. how about we keep this work in the LFX as well?

like this-> Screenshot 2025-02-12 at 11 38 48 AM

Hello @TenzDelek ,

Kindly look at the code once, card-based layouts on blog page is an unnatural fit because:-

-The blog content is written in Markdown (.md/.mdx), which doesn't support dynamic layouts like cards.
-Markdown is statically processed into HTML, making UI customization difficult.
-Docusaurus follows a structured theme optimized for documentation, not for a card-based UI.
-The blog layout is not component-driven like in Next.js or Gatsby.
-Implementing a card-based UI would require overriding Docusaurus’s BlogListPage component.
-Markdown content would need to be converted to structured JSON for React components.
-Custom pagination, styling, and filtering would need to be implemented manually.
-Docusaurus integrates blogs with docs, keeping a consistent structure, while a card UI would break that consistency.
-This is not a simple CSS fix but a fundamental structural change.
-Such a change requires long-term maintenance and could break existing features.
-Docusaurus is optimized for content-focused navigation, making card-based layouts an unnatural fit.

@TenzDelek
Copy link

TenzDelek commented Feb 12, 2025

Kindly look at the code once

checkout the blogpost component. and you will get a clearer idea. I think you are confuse a bit here. what I am suggesting is not to change the structure of the mdx in any form. but rather make an entry page for the blog post as attached. (similar to case study)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants