-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI Issue #675: Right Sidebar in KubeEdge Version Blog Page is Too… #681
base: master
Are you sure you want to change the base?
Fix UI Issue #675: Right Sidebar in KubeEdge Version Blog Page is Too… #681
Conversation
…ested and Scrollbar Looks Bad - Increased right sidebar width slightly to prevent content cutoff - Adjusted sidebar item padding, font size, and spacing for better visibility - Removed horizontal scrolling from the sidebar - Ensured no overlap and perfect alignment - Sidebar items now fully visible without left-right scrolling Signed-off-by: harshita roonwal <[email protected]> Signed-off-by: harshita91 <[email protected]>
8a94240
to
8af9a27
Compare
Hello @Shelley-BaoYue , @anvithks , Kindly review the PR and suggest any changes!! Thank you!! |
/assign @Shelley-BaoYue |
Fixes #675 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This work looks good! Can the left sidebar be adjusted in width, or I think it would look better if it was narrower?
Signed-off-by: harshita91 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello @Shelley-BaoYue , @anvithks After making changes according to your suggestions Kindly review the PR ! Thank you so much !! |
hi @Shelley-BaoYue , I have an idea for this. what about we keep the blog content in a card format first then when a user click on it it should show this content. because currently the blog section looks more like a docs. how about we keep this work in the LFX as well? |
Hello @TenzDelek , Kindly look at the code once, card-based layouts on blog page is an unnatural fit because:- -The blog content is written in Markdown (.md/.mdx), which doesn't support dynamic layouts like cards. |
checkout the blogpost component. and you will get a clearer idea. I think you are confuse a bit here. what I am suggesting is not to change the structure of the mdx in any form. but rather make an entry page for the blog post as attached. (similar to case study) |
Fix UI Issue #675
📌 Problem
✅ Solution Implemented
🔧 Files Changed
src/css/custom.css
docusaurus.config.js
🖼️ Screenshots
Before
![image](https://private-user-images.githubusercontent.com/137335511/411947289-7c5ca4fc-7954-4763-91e4-21f815aef766.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTcxMTYsIm5iZiI6MTczOTU5NjgxNiwicGF0aCI6Ii8xMzczMzU1MTEvNDExOTQ3Mjg5LTdjNWNhNGZjLTc5NTQtNDc2My05MWU0LTIxZjgxNWFlZjc2Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNTIwMTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zOTIxZTc5Yzk3ZGVjODcxMTUxYTJhZjUxMmY2ZDQwN2RiOGNmZTk1NDU0MDZmN2UzOTk1MDg0OGZhZDY1YzAzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.OD0rV3sd85-WvCT9ODH4agE0f0lVF7oIU-PqHFQ3VyM)
After
📌 Fixes: #675
🚀 Ready for review!