Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup test automation for github org tests #678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented May 3, 2024

As highlighted here, currently there is no test automation, thus requiring users to run those tests locally and report the result in the PR.
With this change I am proposing a simple GitHub workflow to automatically trigger GitHub org tests on pull request creation.

This will remove, from user perspective, the need to run those tests locally and report results in the PR itself.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lampajr
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @lampajr. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lampajr
Copy link
Member Author

lampajr commented May 3, 2024

I tested the workflow locally using act:

gh act -j tests

and this is an extract from the output:

| ============================= test session starts ==============================
| platform linux -- Python 3.10.13, pytest-8.2.0, pluggy-1.5.0
| rootdir: /home/alampare/kubeflow/internal-acls/github-orgs
| plugins: asyncio-0.23.6
| asyncio: mode=strict
collected 1 item                                                               
| 
| test_org_yaml.py .                                                       [100%]
| 
| ============================== 1 passed in 0.20s ===============================
[Github Org Tests/tests]   ✅  Success - Main Run tests
[Github Org Tests/tests] ⭐ Run Post Set up Python 3.10
...
[Github Org Tests/tests]   ✅  Success - Post Set up Python 3.10
[Github Org Tests/tests] Cleaning up container for job tests
[Github Org Tests/tests] 🏁  Job succeeded

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hbelmiro
Copy link
Contributor

hbelmiro commented May 3, 2024

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants