Remove obsolete TODO

Signed-off-by: Antonin Stefanutti <[email protected]>
kubeflow · Feb 26, 2025 · 09d4672 · 09d4672
1 parent 4417037
commit 09d4672
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/pkg/runtime/runtime.go b/pkg/runtime/runtime.go
@@ -46,12 +46,10 @@ type RuntimePolicy struct {
 type Trainer struct {
 	NumNodes       *int32
 	NumProcPerNode string
-	// TODO (andreyvelich). Potentially, we can use map for env and sort it to improve code.
-	// Context: https://github.com/kubeflow/trainer/pull/2308#discussion_r1823267183
-	Env           []corev1ac.EnvVarApplyConfiguration
-	ContainerPort *corev1ac.ContainerPortApplyConfiguration
-	Volumes       []corev1ac.VolumeApplyConfiguration
-	VolumeMounts  []corev1ac.VolumeMountApplyConfiguration
+	Env            []corev1ac.EnvVarApplyConfiguration
+	ContainerPort  *corev1ac.ContainerPortApplyConfiguration
+	Volumes        []corev1ac.VolumeApplyConfiguration
+	VolumeMounts   []corev1ac.VolumeMountApplyConfiguration
 }
 
 // TODO (andreyvelich): Potentially, we can add ScheduleTimeoutSeconds to the Scheduler for consistency.