Skip to content

Commit

Permalink
Add jobset as a dependency
Browse files Browse the repository at this point in the history
Signed-off-by: Yi Chen <[email protected]>
  • Loading branch information
ChenYi015 committed Feb 25, 2025
1 parent 6144d92 commit a4b36db
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
7 changes: 6 additions & 1 deletion charts/trainer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,17 @@ appVersion: 2.0.0

type: application

dependencies:
- name: jobset
repository: oci://us-central1-docker.pkg.dev/k8s-staging-images/charts
version: 0.8.0
condition: jobset.install

keywords:
- kubeflow trainer

home: https://github.com/kubeflow/trainer

maintainers:
- name: ChenYi015
email: [email protected]
url: https://github.com/ChenYi015
5 changes: 3 additions & 2 deletions charts/trainer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,10 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall) for command docum
|-----|------|---------|-------------|
| nameOverride | string | `""` | String to partially override release name. |
| fullnameOverride | string | `""` | String to fully override release name. |
| jobset.install | bool | `true` | Whether to install jobset as a dependency managed by trainer. This must be set to `false` if jobset controller/webhook has already been installed into the cluster. |
| commonLabels | object | `{}` | Common labels to add to the resources. |
| image.registry | string | `"docker.io"` | Image registry. |
| image.repository | string | `"kubeflow/trainer-controller-controller"` | Image repository. |
| image.repository | string | `"kubeflow/trainer-controller-manager"` | Image repository. |
| image.tag | string | If not set, the chart appVersion will be used. | Image tag. |
| image.pullPolicy | string | `"IfNotPresent"` | Image pull policy. |
| image.pullSecrets | list | `[]` | Image pull secrets for private image registry. |
Expand Down Expand Up @@ -102,4 +103,4 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall) for command docum

| Name | Email | Url |
| ---- | ------ | --- |
| ChenYi015 | <[email protected]> | <https://github.com/ChenYi015> |
| ChenYi015 | | <https://github.com/ChenYi015> |
5 changes: 5 additions & 0 deletions charts/trainer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ nameOverride: ""
# -- String to fully override release name.
fullnameOverride: ""

jobset:
# -- Whether to install jobset as a dependency managed by trainer.
# This must be set to `false` if jobset controller/webhook has already been installed into the cluster.
install: true

# -- Common labels to add to the resources.
commonLabels: {}

Expand Down

0 comments on commit a4b36db

Please sign in to comment.