KEP-2170: Add the manifests overlay for Kubeflow Training V2 #2382
+107
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: kubeflow-trainer-admin | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-admin: "true" | ||
| aggregationRule: | ||
| clusterRoleSelectors: | ||
| - matchLabels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-trainer-admin: "true" | ||
| rules: [] | ||
|
|
||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: kubeflow-trainer-edit | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-edit: "true" | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-trainer-admin: "true" | ||
| rules: | ||
| - apiGroups: | ||
| - kubeflow.org | ||
| resources: | ||
| - clustertrainingruntimes | ||
| - trainingruntimes | ||
| - trainjobs | ||
| verbs: | ||
| - create | ||
| - delete | ||
| - get | ||
| - list | ||
| - patch | ||
| - update | ||
| - watch | ||
| - apiGroups: | ||
| - kubeflow.org | ||
| resources: | ||
| - trainjobs/status | ||
| verbs: | ||
| - get | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - persistentvolumeclaims | ||
|
There was a problem hiding this comment. This is not required for now, please remove it. |
||
| verbs: | ||
| - create | ||
| - delete | ||
| - get | ||
| - list | ||
| - watch | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - events | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
|
|
||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: kubeflow-trainer-view | ||
| labels: | ||
| rbac.authorization.kubeflow.org/aggregate-to-kubeflow-view: "true" | ||
| rules: | ||
| - apiGroups: | ||
| - kubeflow.org | ||
| resources: | ||
| - clustertrainingruntimes | ||
| - trainingruntimes | ||
| - trainjobs | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| - apiGroups: | ||
| - kubeflow.org | ||
| resources: | ||
| - trainjobs/status | ||
| verbs: | ||
| - get | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| namespace: kubeflow | ||
| resources: | ||
| - ../../base/crds | ||
| - ../../base/manager | ||
| - ../../base/rbac | ||
| - ../../base/webhook | ||
| - ../../base/runtimes/pretraining | ||
|
There was a problem hiding this comment. The runtimes must be installed after controller-manager is ready. |
||
| - ../../third-party/jobset # Comment this line if JobSet is installed on the Kubernetes cluster. | ||
| - kubeflow-trainer-roles.yaml | ||
|
|
||
| # Update the Kubeflow Trainer controller manager image tag. | ||
| images: | ||
| - name: kubeflow/trainer-controller-manager | ||
| newTag: latest | ||
|
|
||
| # Secret for the Kubeflow Training webhook. | ||
| secretGenerator: | ||
| - name: kubeflow-trainer-webhook-cert | ||
| namespace: kubeflow | ||
| options: | ||
| disableNameSuffixHash: true | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we also should have permission to read logs from TrainJob's pods.