Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: K8s 1.32 #2448

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

manojks1999
Copy link

What this PR does / why we need it:
Upgrade to k8s 1.32

Fixes #2434

Checklist:

  • [ * ] Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @manojks1999!
You also, need to update Go modules and required changes in the controller.
Check example here: #2330

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manojks1999 You may also need to look into the changelog of v1.32.2 and to see what changes we should make to trainer.

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.32.md#changelog-since-v1310

@tenzen-y
Copy link
Member

I just synced with @andreyvelich about this one. Actually this is blocking many things, but we do not want to reject @manojks1999 contributions. So, we decided to do module upgrading by myself in another PR, and then you can focus only on behavior checking which means adding 1.32 to CI

@andreyvelich
Copy link
Member

@manojks1999 Please rebase your PR after this change: #2434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kubernetes v1.32
4 participants