-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: K8s 1.32 #2448
base: master
Are you sure you want to change the base?
Upgrade: K8s 1.32 #2448
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this @manojks1999!
You also, need to update Go modules and required changes in the controller.
Check example here: #2330
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manojks1999 You may also need to look into the changelog of v1.32.2 and to see what changes we should make to trainer.
I just synced with @andreyvelich about this one. Actually this is blocking many things, but we do not want to reject @manojks1999 contributions. So, we decided to do module upgrading by myself in another PR, and then you can focus only on behavior checking which means adding 1.32 to CI |
@manojks1999 Please rebase your PR after this change: #2434 |
What this PR does / why we need it:
Upgrade to k8s 1.32
Fixes #2434
Checklist: