If the IP is on the lo device already don't fail

[dprotaso]

This might be the fix for #189 or #192

[aojea]

great catch, I think we may keep that the same and instead, on the caller, just ignore the error and log, but not stop the loadbalancer creation, since the tunnels may have different errors on different OS I think this approach is more resilient

cloud-provider-kind/pkg/loadbalancer/server.go

Lines 120 to 126 in defae81

	if s.tunnelManager != nil {
	klog.V(2).Infof("updating loadbalancer tunnels on userspace")
	err = s.tunnelManager.setupTunnels(loadBalancerName(clusterName, service))
	if err != nil {
	return nil, err
	}
	}

replacing return nil, err by a log klog.Infof("Failed to create tunn: %v", err)

[aojea]

wrap the error here, I think this tunnel is ok to return the error ... I find better if we swallow it here by logging it at normal level, as the tunnel is an addon for certain environments it should not block the loadbalancer creation but it should be easy for the user to find the error in the logs

cloud-provider-kind/pkg/loadbalancer/server.go

Lines 120 to 126 in defae81

	if s.tunnelManager != nil {
	klog.V(2).Infof("updating loadbalancer tunnels on userspace")
	err = s.tunnelManager.setupTunnels(loadBalancerName(clusterName, service))
	if err != nil {
	return nil, err
	}
	}

[dprotaso]

pushed - take a look at the edits

[aojea]

/approve

one change only for final lgtm #205 (comment)

Thanks

[k8s-ci-robot]

@dprotaso: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-kind-conformance-parallel-ga-only	768e95c	link	false	/test pull-cloud-provider-kind-conformance-parallel-ga-only

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[aojea]

/lgtm
/approve

Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment