-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "make Private IP of the internal LB of the API Server configurable" #5295
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/close |
@nawazkh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Closed this since it is better I revert all the Internal LB changes in one PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5295 +/- ##
==========================================
- Coverage 52.57% 52.53% -0.04%
==========================================
Files 272 272
Lines 29408 29372 -36
==========================================
- Hits 15462 15432 -30
+ Misses 13148 13143 -5
+ Partials 798 797 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
/reopen |
@nawazkh: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
LGTM label has been added. Git tree hash: d0a0cf88a13bc8aff127bc8dc8f6e13cdfa1db5a
|
Reverts #5274
Based off of discussion here #5293 (comment) and #5293 (comment), deciding to revert the internal LB changes.
For : #5264