Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Bump to controller-runtime v0.20 & controller-tools v0.17 #11633

Merged
merged 9 commits into from
Jan 17, 2025
Merged

⚠️ Bump to controller-runtime v0.20 & controller-tools v0.17 #11633

merged 9 commits into from
Jan 17, 2025

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Dec 31, 2024 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Contains:

  • Bump to CR v0.20 & CT v0.17
  • Bump to Go 1.23
  • Bump to conversion-gen v0.32, openapi-gen 2c72e55
  • Regenerate manifests (after CT bump)
  • Set DefaulterRemoveUnknownOrOmitableFields webhook option to preserve previous behavior
  • Remove test utils for removed Validator/Defaulter
  • Adjust unit tests to k8s.io/* v1.32.0
    • Upstream packages got moved around a bit

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #11064

Related kubernetes/test-infra#34157

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 31, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 31, 2024
@sbueringer sbueringer added the area/dependency Issues or PRs related to dependency changes label Dec 31, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 31, 2024
@sbueringer sbueringer changed the title [WIP] ⚠️ Bump to controller-runtime v0.20 & controller-tools v0.17 [WIP] ⚠️ Bump to CR v0.20 & CT v0.17, add PriorityQueue feature gate Jan 2, 2025
@sbueringer sbueringer force-pushed the pr-bump-cr-ct branch 2 times, most recently from acde1a9 to 36d05a5 Compare January 3, 2025 11:25
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 3, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 3, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
@sbueringer sbueringer force-pushed the pr-bump-cr-ct branch 4 times, most recently from c0ac89b to 5fa1586 Compare January 16, 2025 12:13
@sbueringer
Copy link
Member Author

Tests will be green with the final CR release that will contain: kubernetes-sigs/controller-runtime#3074

@sbueringer sbueringer changed the title [WIP] ⚠️ Bump to CR v0.20 & CT v0.17, add PriorityQueue feature gate [WIP] ⚠️ Bump to CR v0.20 & CT v0.17 Jan 16, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 16, 2025
@sbueringer sbueringer mentioned this pull request Jan 16, 2025
Closed
17 tasks
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 691fa21 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

Danil-Grigorev
Danil-Grigorev approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dd4767644f859cc1424b3f554d204bbf9982cd0c

@sbueringer
Copy link
Member Author

sbueringer commented Jan 16, 2025 •
edited
Loading

/hold

Forgot to bump the cloudbuild image. Working on bumping the image to Go 1.23 in test-infra. Will add one commit in a bit (but feel free to review this PR already)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2025
@chrischdi
Copy link
Member

Lgtm, pending GCB :-)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

/hold cancel

ready now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
fabriziopandini
fabriziopandini reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: af6c368cd03640858d3d13d37d8030f7df079590

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 99e9a26 into kubernetes-sigs:main Jan 17, 2025
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jan 17, 2025
@sbueringer sbueringer deleted the pr-bump-cr-ct branch January 17, 2025 14:42
@sbueringer sbueringer changed the title ⚠️ Bump to controller-runtime v0.20 & controler-tools v0.17 ⚠️ Bump to controller-runtime v0.20 & controller-tools v0.17 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@g-gaston g-gaston Awaiting requested review from g-gaston

@Danil-Grigorev Danil-Grigorev Awaiting requested review from Danil-Grigorev

Assignees

@fabriziopandini fabriziopandini

@Danil-Grigorev Danil-Grigorev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @k8s-ci-robot @chrischdi @fabriziopandini @Danil-Grigorev