⚠️ Config: Disable client-side ratelimiter by default #3119
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
force-pushed
the
default-disable
branch
2 times, most recently
from
f7f320b to
6ae5840
Compare
| @@ -61,6 +61,9 @@ func RegisterFlags(fs *flag.FlagSet) { | |||
| // If --kubeconfig is set, will use the kubeconfig file at that location. Otherwise will assume running | |||
| // in cluster and use the cluster provided kubeconfig. | |||
| // | |||
| // The returned `*rest.Config` has client-side ratelimting disabled as we can rely on API priority and | |||
There was a problem hiding this comment.
Is it worth mentioning what the previous default configuration would have been for users who wish to restore/maintain the previous behaviour?
There was a problem hiding this comment.
IMHO no - We never documented the previous default either and I don't know why it existed
There was a problem hiding this comment.
We can mention it in release notes
There was a problem hiding this comment.
Ack, release notes is fine by me
Sig-Apimachinery recommends [disabling the client-side ratelimiter][0] and rely on API priority and fairness instead for any [Kubernetes version >= 1.22][1]. Update our config getters to do that. 0: https://kubernetes.slack.com/archives/C0EG7JC6T/p1680889646346859?thread_ts=1680791299.631439&cid=C0EG7JC6T 1: https://kubernetes.slack.com/archives/C0EG7JC6T/p1680892224956789?thread_ts=1680791299.631439&cid=C0EG7JC6T
alvaroaleman
force-pushed
the
default-disable
branch
from
6ae5840 to
ab40409
Compare
|
/lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fbe73930624db8e60c8043c029dc2b238efd50c0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sig-Apimachinery recommends disabling the client-side ratelimiter and rely on API priority and fairness instead for any Kubernetes version >= 1.22. Update our config getters to do that.