PodMatchNodeSelector: Replaced PodMatchNodeSelector implementation wi…

[jandai]

reduce code size and optimize

[k8s-ci-robot]

Hi @jandai. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jandai]

ping @a7i @knelasevero

[a7i]

/ok-to-test

[jandai]

/retest

[jandai]

Unnecessary to import k8s.io/kubernetes/plugin/pkg/scheduler/algorithm/predicates or copied and implement them again

[googs1025]

Unnecessary to import k8s.io/kubernetes/plugin/pkg/scheduler/algorithm/predicates or copied and implement them again

Yes, this will reduce the complexity of code maintenance. 👍

[googs1025]

hi, @jandai can you help confirm whether the logic in the k/k package is the same as the logic in the descheduler? Or you have confirmed this clearly?

[jandai]

hi, @jandai can you help confirm whether the logic in the k/k package is the same as the logic in the descheduler? Or you have confirmed this clearly?

I've confirmed it. it matches the NodeSelector and the requiredDuringSchedulingIgnoredDuringExecution of nodeAffinity, which do the same thing as implemented by the descheduler. Kindly plz double-check as well

[googs1025]

/lgtm

[a7i]

/approve

Thank you for your contribution! 🏆

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [a7i]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment