Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some chore issue #1637

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: fix some chore issue #1637

wants to merge 2 commits into from

Conversation

googs1025
Copy link
Member

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2025
@k8s-ci-robot k8s-ci-robot requested a review from a7i February 25, 2025 01:36
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign seanmalloy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 25, 2025
@googs1025 googs1025 marked this pull request as ready for review February 25, 2025 01:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2025
@googs1025
Copy link
Member Author

/cc @ingvagabund

@ingvagabund
Copy link
Contributor

Thank you for the swift fix. Would you please accompany the fix with a simple unit test? Having setDefaultEvictor return an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7i a7i Awaiting requested review from a7i

@knelasevero knelasevero Awaiting requested review from knelasevero

@jklaw90 jklaw90 Awaiting requested review from jklaw90

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@googs1025 @k8s-ci-robot @ingvagabund