-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(proposal): support multiple replicas with leader election #5051
base: master
Are you sure you want to change the base?
docs(proposal): support multiple replicas with leader election #5051
Conversation
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
/kind documentation |
@ivankatliarchuk You need to link this doc in mkdocs.yml, like the other proposal, see here. There is a typo in the diagram: "urrentLeader" instead of "CurrentLeader". BTW, if you can do the schema with mermaid instead of a png, it's (way) easier to maintain it. See https://kubernetes.io/docs/contribute/style/diagram-guide/ |
Co-authored-by: Michel Loiseleur <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Addressed |
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's quite clear 👍 .
See my suggestion for minor improvements.
I'm unsure if you really wanted to add internal/testutils/logs.go
to this PR ?
Co-authored-by: Michel Loiseleur <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Yeah, that logs.go could w8. Removed. |
/retitle docs(proposal): support multiple replicas with leader election |
/lgtm @szuecs @Raffo @Dadeos-Menlo You are more than welcome to review this proposal 🙏 |
Part of #2430 |
/kind proposal |
@ivankatliarchuk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ivan katliarchuk <[email protected]>
* master: docs: add deprecation policy (kubernetes-sigs#5053) style: space vs tabs fix: remove misleading error message fix(cloudflare): ignore 1002 permission denied errors in UpdateDataLocalizationRegionalHostname
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added header
|
/kind feature |
Description
Full pull request is here #5033
Motivation for split #4598 (comment)
The plan is to add documentation, and move main logic from
main.go
to it's own function as part of this pull request. This should help to focus on testing an actual feature, without constant need to rebasemain.go
file. Currently all the flags changes affectsmain.go
, this may need to be addressed at some point as well.Checklist