chore(filter-tags): pre-process filter tags #5063
Open
+28
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up for a pull request #5060
In previous pull-request, I found a side effect for tags filter where Tag has no Key but only value set.
For me it looks like a bug that could be a feature. Let me know if it should be supported. I've actually added the test to highlight this in previous pull request. If we keep the behaviour where key is empty and value is provided, I'll update the documentation and logic
Design of actual pre-processing was discussed here #5042
Checklist