Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(filter-tags): pre-process filter tags #5063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Feb 5, 2025

Description

This is a follow-up for a pull request #5060

In previous pull-request, I found a side effect for tags filter where Tag has no Key but only value set.
For me it looks like a bug that could be a feature. Let me know if it should be supported. I've actually added the test to highlight this in previous pull request. If we keep the behaviour where key is empty and value is provided, I'll update the documentation and logic

Screenshot 2025-02-05 at 08 56 07

Design of actual pre-processing was discussed here #5042

BenchmarkZoneTagFilterMatchBasic-16    	 2593248	       460.1 ns/op
BenchmarkZoneTagFilterComplex-16    	  754824	      1474 ns/op

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2025
@ivankatliarchuk ivankatliarchuk changed the title chore(filter-tags): pre-process tags chore(filter-tags): pre-process filter tags Feb 5, 2025
@mloiseleur
Copy link
Contributor

In previous pull-request, I found a side effect for tags filter where Tag has no Key but only value set.
For me it looks like a bug that could be a feature. Let me know if it should be supported.

TBH, I do not know. It looks like a bug to me, at first glance.
@Raffo @szuecs: wdyt ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants