-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose drifted nodeclaim condition status to printer column output #1846
base: main
Are you sure you want to change the base?
feat: Expose drifted nodeclaim condition status to printer column output #1846
Conversation
Signed-off-by: Cameron McAvoy <[email protected]>
b14a101
to
3e279e2
Compare
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
/assign @engedaam |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
/reopen |
@rschalo: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cnmcavoy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 13439926404Details
💛 - Coveralls |
@@ -32,6 +32,9 @@ spec: | |||
- jsonPath: .status.conditions[?(@.type=="Ready")].status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to tell, but I think that this PR might be in need of a rebase
@@ -32,6 +32,9 @@ spec: | |||
- jsonPath: .status.conditions[?(@.type=="Ready")].status | |||
name: Ready | |||
type: string | |||
- jsonPath: .status.conditions[?(@.type=="Drifted")].status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How common do you think it will be for folks to look this up? I definitely can see it as useful -- what do you think about starting this in the -o wide
output with priority=1
and then elevating it if we hear from more folks that they'd like to see it in the non-wide output?
Fixes #1464
Description
feat: Expose drifted nodeclaim condition status to printer column output. Updates the nodeclaim reconcile to not clear the condition, but set the drifted condition state to false. Tests were similarly updated for this change in behavior.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.