Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose drifted nodeclaim condition status to printer column output #1846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cnmcavoy
Copy link
Contributor

Fixes #1464

Description
feat: Expose drifted nodeclaim condition status to printer column output. Updates the nodeclaim reconcile to not clear the condition, but set the drifted condition state to false. Tests were similarly updated for this change in behavior.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2024
@cnmcavoy cnmcavoy force-pushed the cmcavoy/nodeclaim-drifted-status branch from b14a101 to 3e279e2 Compare November 26, 2024 23:12
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2024
@engedaam
Copy link
Contributor

/assign @engedaam

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2024
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2024
@github-actions github-actions bot closed this Jan 11, 2025
@rschalo
Copy link
Contributor

rschalo commented Feb 20, 2025

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

@rschalo: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cnmcavoy
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13439926404

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 81.39%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/controller.go 2 71.65%
pkg/controllers/provisioning/scheduling/nodeclaim.go 3 86.98%
pkg/test/expectations/expectations.go 4 94.42%
Totals Coverage Status
Change from base Build 13435057598: 0.04%
Covered Lines: 9228
Relevant Lines: 11338

💛 - Coveralls

@@ -32,6 +32,9 @@ spec:
- jsonPath: .status.conditions[?(@.type=="Ready")].status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to tell, but I think that this PR might be in need of a rebase

@@ -32,6 +32,9 @@ spec:
- jsonPath: .status.conditions[?(@.type=="Ready")].status
name: Ready
type: string
- jsonPath: .status.conditions[?(@.type=="Drifted")].status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How common do you think it will be for folks to look this up? I definitely can see it as useful -- what do you think about starting this in the -o wide output with priority=1 and then elevating it if we hear from more folks that they'd like to see it in the non-wide output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/closed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance v1 NodeClaim print output to show drifted state
6 participants