fix: Don't panic on multiple $patch: delete strategic merge patches in a single patch file

[tdemin]

Fixes #5552.

Removing a resource entirely with a $patch: delete patch internally yields a resource that has no content (and hence no GVKNN), so calls to (*resource.Resource).CurId() would panic.

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[linux-foundation-easycla]

• ✅login: tdemin / (7a89623)
• ✅login: tdemin / (7a89623, 7165d72)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @tdemin!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tdemin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tdemin
Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[koba1t]

/ok-to-test

[koba1t]

Hi @tdemin
I appreciate for taking the problem that was abandoned for a long time!

So, According to the test in my local PC, func TestSinglePatchWithMultiplePatchDeleteDirectives(t *testing.T) was passed even if there were no modifications to the code.
Could you rewrite the test case to detect regression to prevent this bug from recurring?

FYI, This sentence might be helpful.
https://github.com/kubernetes-sigs/kustomize/blob/master/CONTRIBUTING.md#reviewer-guide

- The PR should have two distinct commits:
  - The first commit should add a test demonstrating incorrect behavior
  - The second commit should include the bug fix