feat(helm): allow the use of devel alias for helmcharts

[milkshake308]

Hello,
This pull request adds support for an explicit devel option in helmCharts definitions within kustomization.yaml. This allows users to enable Helm's --devel flag directly, facilitating the use of development releases without relying on implicit version constraints.

Previously, one had to work around this limitation by specifying a version constraint like ">0.0.0-0", which was functionally equivalent to --devel. For example:

helmCharts:
- name: sm-operator
  releaseName: sm-operator
  namespace: bitwarden
  repo: https://charts.bitwarden.com/
  valuesFile: bitwarden-sm-op-values.yaml
  version: ">0.0.0-0" # equivalent for "--devel"

With this PR, users can explicitly enable development releases using the devel field:

helmCharts:
- name: sm-operator
  releaseName: sm-operator
  namespace: bitwarden
  repo: https://charts.bitwarden.com/
  valuesFile: bitwarden-sm-op-values.yaml
  version: "0.1.0-Beta"
  devel: true

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: milkshake308 / name: Aaron S (5036c07, 418f233, c5f69b0)

[k8s-ci-robot]

Welcome @milkshake308!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @milkshake308. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stormqueen1990]

Hello there, @milkshake308! Thank you very much for your PR!

Could you please add a few test cases to this implementation, demonstrating that the new flag will be added only when your new option devel is specified? I'm thinking something similar to how tests were implemented in #5751 for plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go and api/types/helmchartargs.go.

Please let me know if you have any questions!

[stormqueen1990]

/test all

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: milkshake308

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[milkshake308]

Hi @stormqueen1990
I had some unfortunate issues trying to make a test case that assert argument presence with HelmChartInflationGenerator_test.go (due to the fact that I was not able to make delve work with it);
However since the conditionnal that add the arg for helm pullCommand was identical to the AsHelmArgs I figured that the assertion could be added instead to helmchartargs_test.go to assert with AsHelmArgs
Does this approach align with what you were expecting?

[stormqueen1990]

Hi @stormqueen1990 I had some unfortunate issues trying to make a test case that assert argument presence with HelmChartInflationGenerator_test.go (due to the fact that I was not able to make delve work with it); However since the conditionnal that add the arg for helm pullCommand was identical to the AsHelmArgs I figured that the assertion could be added instead to helmchartargs_test.go to assert with AsHelmArgs Does this approach align with what you were expecting?

Hi there, @milkshake308! The test cases you added make sense to me. Thanks for working on that!

/test all

[stormqueen1990]

/lgtm

/assign @koba1t
for maintainer review

[stormqueen1990]

@milkshake308: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

@milkshake308 it looks like one of the tests didn't pass in Prow (Helm couldn't find the development version 0.1.0-Beta for chart test-chart). I think you intended to use chart sm-operator, so maybe the fields are mixed up?

You can check the logs from Prow through the kustomize-presubmit-master job link in the checks section below.

/remove-lgtm

[milkshake308]

Indeed I did not named the chart correctly, I assumed these were placeholder values.
I pushed a fix that use a real chart requiring the "developpement release" and fix the value assertion
/retest

[k8s-ci-robot]

@milkshake308: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

I did not named the chart correctly, I assumed these were placeholder values.
I pushed a fix that use a real chart requiring that is in "developpement release" and fix the value assertion
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stormqueen1990]

/retest

[stormqueen1990]

/lgtm